Salla Theme Reviewer

Catch Salla review rejections before you submit — right inside VS Code.

Salla Theme Reviewer analyzes your Twilight theme against the rules Salla's review team actually applies, built from the analysis of 123 real rejection emails. Findings appear in the Problems panel on the exact line, every save re-checks instantly, and one command turns the same checks into commit, push, and pull-request gates for your whole team.

Diagnostics and reports are in Arabic on purpose — they match the language of Salla's review feedback, so you can compare findings one-to-one with official rejection notes.

• ⚡ Fast: full theme scan ≈ 0.4 s, saving a file re-checks in ≈ 65 ms — never blocks the editor
• 📴 Private: everything runs locally; internet is used only for the npm version check and reference updates
• 🧩 Works with classic themes (twilight.json) and component bundles (twilight-bundle.json)

Getting Started

1. Open your theme folder in VS Code — the extension activates automatically.
2. Open the Problems panel (Ctrl+Shift+M) and click any finding to jump to its line.
3. Save a file — it is re-checked instantly.
4. Before submitting: Ctrl+Shift+P → Salla Review: Generate Report for a shareable Markdown report in the reviewers' own format.

The status bar shows ✓ Salla when your theme is clean, or a live error/warning tally.

What It Checks

Everything below was a real rejection reason. 🔴 blocks approval, 🟡 needs fixing or review, 🔵 is advisory.

Texts & translation

Twig

Structure & platform requirements

twilight.json

Security & policy

Code quality

Bundle projects additionally get: multilanguage fields without a localizedString resolver, console.log in production code, unsafeHTML, missing dist/, and missing vite.config.

Your Own Rules

Salla adds review rules faster than any extension can ship. When that happens you do not have to wait for an update — define the rule yourself, and the editor, the git hooks, and CI enforce it exactly like a built-in check.

Run Salla Review: Edit Custom Rules. It creates salla-rules.json in your theme (with a documented template) and opens it. Save the file and the rules apply immediately. Commit it so your whole team gets them.

{
  "rules": [
    {
      "id": "no-external-fonts",
      "name": "No external font CDNs",
      "message": "Bundle fonts locally instead of loading them from Google",
      "severity": "error",              // error blocks commits and CI
      "files": "src/views/**/*.twig",
      "forbid": "fonts\\.(googleapis|gstatic)\\.com"
    },
    {
      "id": "require-loyalty-widget",
      "name": "Loyalty widget is now mandatory",
      "files": "src/views/**/*.twig",
      "require": "<salla-loyalty-widget",
      "scope": "theme",                 // must appear in at least one file
      "severity": "error",
      "docs": "https://docs.salla.dev/"
    }
  ]
}

Mistakes in the rules file — a missing id, a duplicate, an invalid regular expression, malformed JSON — are reported on the rules file itself, so a broken rule is never silently skipped. Comments and trailing commas are allowed.

The Report

Salla Review: Generate Report writes reports/<theme>-report.md and opens it: a summary table first (total, count per type, severity), then findings grouped by type — most severe first — each with file, line, and a context snippet. It also includes a comparison against the official theme-raed reference: platform components and APIs Raed uses that your theme doesn't.

Commit / Push / Merge Gates

Run Salla Review: Setup Git & CI Checks once. It adds to your repository:

The GitHub check reports like Salla's own TwilightCI: a check table in the run summary ("❌ 2 of 9 checks failed · commit 065b8e7") with What-to-fix details, plus inline annotations on the exact lines in the Files changed view. GitHub notifies the commit author automatically when the check fails. Require the check in branch protection to gate merges.

Everything is self-contained — teammates and CI need nothing installed. Commit the generated files; each teammate runs git config core.hooksPath .githooks once after cloning. Bypass a gate when needed with --no-verify or SALLA_REVIEW_SKIP=1.

Configure the gates in Settings → Git & CI Checker: which hooks and workflow to generate, and whether error, warning, or any findings block.

Commands

Settings

Open Settings → Extensions → Salla Review. Eight collapsible sections: General, Scan Scope (Exclude), Checks, Twig Checks, Raed Reference Checks, Bundle Projects Only, Git & CI Checker, and Custom Rules. Every check has its own checkbox, and every setting can be set per project in the theme's own .vscode/settings.json — commit that file and your team, the git hooks, and CI all enforce the same rules.

Excluding files and folders

sallaReview.exclude accepts four pattern forms:

// <theme>/.vscode/settings.json
{
  "sallaReview.exclude": ["src/views/components/custom", "/\\.min\\.js$/"],
  "sallaReview.checks.colors": false,
  "sallaReview.ci.failOn": "error"
}

sallaReview.ignoredTexts whitelists specific strings from the hardcoded-text check.

Command Line

The same engine runs standalone — useful for scripting or reviewing many themes:

node .salla-review/cli.js <path> [--fail-on error] [--exclude "p1,p2"] [--no-colors] ...

Every check has a --no-* flag; --fail-on error|warning|any sets the exit-code gate; the project's .vscode/settings.json is applied automatically. (The .salla-review/ folder appears after running Setup Git & CI Checks.)

The Raed Reference

Several checks compare against theme-raed, Salla's official reference theme, which changes frequently. The extension refreshes its reference fingerprint from GitHub automatically every 7 days (sallaReview.raedAutoUpdateDays), or on demand via Salla Review: Update Raed Reference.

Troubleshooting

Good to know: a clean run is strong evidence, not a guarantee — Salla's reviewers also perform visual and store-configuration review that no static tool can replace. Twig expressions inside tags and hand-written fake statistics still need human eyes.

Contact

Built by Omar Mazen. Questions, bug reports, or a rejection reason the extension does not catch yet — reach out:

• Email: omar.mazen.mohammed@gmail.com
• LinkedIn: https://www.linkedin.com/in/omar-mazen/
• GitHub: https://github.com/omar-mazen